Skip to content

Conversation

@Kanchan-Microsoft
Copy link
Contributor

Purpose

This pull request updates the infrastructure code to enhance tag management for resource groups and corrects the dependency order in the deployment template. The most significant changes are focused on ensuring that resource group tags are properly merged and that dependencies are accurately specified.

Tag Management Improvements:

  • Updated the resourceGroupTags resource in main.bicep to merge the existing resource group tags (resourceGroup().tags) with allTags, ensuring all relevant tags are preserved and applied.
  • Modified the tags property in main.json to use a shallowMerge that now includes resourceGroup().tags along with allTags and other template-defined tags. This ensures that tags defined at the resource group level are not lost during deployment.

Deployment Template and Dependency Fixes:

  • Corrected the order of dependencies in the dependsOn array in main.json by moving the openAI private DNS zone dependency after the aiServices and cognitiveServices DNS zones, ensuring proper resource deployment sequencing.
  • Updated the Bicep-generated template hash in main.json to reflect the changes in the infrastructure code.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Prajwal-Microsoft Prajwal-Microsoft merged commit 78bef7b into dev Oct 28, 2025
6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants